Thread (4 messages) 4 messages, 3 authors, 2021-06-29
STALE1845d LANDED

[PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP

From: Wenbin Mei <hidden>
Date: 2021-06-15 03:01:18
Also in: linux-arm-kernel, linux-devicetree, linux-mmc, lkml
Subsystem: mediatek mmc/sd/sdio driver, multimedia card (mmc), secure digital (sd) and sdio subsystem, open firmware and flattened device tree bindings, the rest · Maintainers: Chaotian Jing, Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds

MT8195 mmc host IP is compatible with MT8183, and currently it shows:
properties:
  compatible:
    oneOf:
...
      - items:
         - const: mediatek,mt8192-mmc
         - const: mediatek,mt8195-mmc
         - const: mediatek,mt8183-mmc
which means the compatible string in the device tree would be:
	compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc",
		     "mediatek,mt8183-mmc";
The bindings is wrong and that isn't the result we want.
instead we want:
properties:
  compatible:
    oneOf:
...
      - items:
         - const: mediatek,mt8192-mmc
         - const: mediatek,mt8183-mmc
      - items:
         - const: mediatek,mt8195-mmc
         - const: mediatek,mt8183-mmc
which would give us:
	compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
and
	compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc";

Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195)
Signed-off-by: Wenbin Mei <redacted>
---
 Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index 8648d48..adaba90 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -31,6 +31,8 @@ properties:
           - const: mediatek,mt2701-mmc
       - items:
           - const: mediatek,mt8192-mmc
+          - const: mediatek,mt8183-mmc
+      - items:
           - const: mediatek,mt8195-mmc
           - const: mediatek,mt8183-mmc
 
-- 
1.9.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help