Thread (18 messages) 18 messages, 6 authors, 2021-07-01

Re: [PATCH v1 2/3] scsi: ufs: Optimize host lock on transfer requests send/compl paths

From: Stanley Chu <hidden>
Date: 2021-06-03 02:54:31
Also in: linux-arm-kernel, linux-scsi, lkml

Hi Can,

On Mon, 2021-05-24 at 01:36 -0700, Can Guo wrote:
Current UFS IRQ handler is completely wrapped by host lock, and because
ufshcd_send_command() is also protected by host lock, when IRQ handler
fires, not only the CPU running the IRQ handler cannot send new requests,
the rest CPUs can neither. Move the host lock wrapping the IRQ handler into
specific branches, i.e., ufshcd_uic_cmd_compl(), ufshcd_check_errors(),
ufshcd_tmc_handler() and ufshcd_transfer_req_compl(). Meanwhile, to further
reduce occpuation of host lock in ufshcd_transfer_req_compl(), host lock is
no longer required to call __ufshcd_transfer_req_compl(). As per test, the
optimization can bring considerable gain to random read/write performance.

Cc: Stanley Chu <redacted>
Co-developed-by: Asutosh Das <redacted>
Signed-off-by: Asutosh Das <redacted>
Signed-off-by: Can Guo <redacted>
According to my test, the performance indeed has impressive improvement
with this series!

Reviewed-by: Stanley Chu <redacted>



 #endif
 
 	bool req_abort_skip;
-	bool in_use;
 };
 
 /**
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help