On Wed, May 19, 2021 at 10:31 PM Alexandre Courbot
[off-list ref] wrote:

+#include "media/videobuf2-v4l2.h"
+#include <media/videobuf2-dma-contig.h>
+#include <media/v4l2-event.h>
+#include <media/v4l2-mem2mem.h>
+#include <linux/module.h>
+
+#include "mtk_vcodec_drv.h"
+#include "mtk_vcodec_dec.h"
+#include "mtk_vcodec_intr.h"
+#include "mtk_vcodec_util.h"
+#include "vdec_drv_if.h"
+#include "mtk_vcodec_dec_pm.h"

Would be good practice to separate <...> and "..." inclusion and sort them.

+static void mtk_vdec_worker(struct work_struct *work)
+{
+       struct mtk_vcodec_ctx *ctx =
+               container_of(work, struct mtk_vcodec_ctx, decode_work);
+       struct mtk_vcodec_dev *dev = ctx->dev;
+       struct vb2_v4l2_buffer *vb2_v4l2_src, *vb2_v4l2_dst;
+       struct vb2_buffer *vb2_src;
+       struct mtk_vcodec_mem *bs_src;
+       struct mtk_video_dec_buf *dec_buf_src;
+       struct media_request *src_buf_req;
+       struct vdec_fb *dst_buf;
+       bool res_chg = false;
+       int ret;
+
+       vb2_v4l2_src = v4l2_m2m_next_src_buf(ctx->m2m_ctx);
+       if (vb2_v4l2_src == NULL) {

To be neat, !vb2_v4l2_src.

+       vb2_v4l2_dst = v4l2_m2m_next_dst_buf(ctx->m2m_ctx);
+       if (vb2_v4l2_dst == NULL) {

To be neat, !vb2_v4l2_dst.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek