Thread (3 messages) 3 messages, 2 authors, 2021-03-16

Re: [PATCH] MIPS: ralink: select WEAK_REORDERING_BEYOND_LLSC on MT7621

From: Ilya Lipnitskiy <hidden>
Date: 2021-03-16 00:41:19
Also in: linux-mips, lkml

Hi Thomas,

On Fri, Mar 12, 2021 at 2:34 AM Thomas Bogendoerfer
[off-list ref] wrote:
On Sun, Mar 07, 2021 at 11:08:06AM -0800, Ilya Lipnitskiy wrote:
quoted
Upstream a long-standing OpenWrt patch for RALINK MT7621 SoC. Selecting
WEAK_REORDERING_BEYOND_LLSC fixes random kernel hangs. This bug and fix
was reported by MediaTek WCN division [0].

[0]: https://lists.infradead.org/pipermail/lede-commits/2017-August/004537.html
I don't see the Mediatek WCN reporting there. Looking at the 1004K user
manual I couldn't find a notice about such behaviour. So this looks
more like a fix for papering over the real bug by just introducing
a few more syncs. Could you please point me to where this is
really documented ?
You may actually be right. After doing some testing we may not need
this change after all. Let me drop this patch for now. FYI, the
following commit may have fixed LL SC issues this change was covering
up: https://lore.kernel.org/lkml/20190613134933.048961704@infradead.org/ (local)
Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
Ilya

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help