Re: [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
From: Gene Chen <hidden>
Date: 2021-03-02 08:24:37
Also in:
linux-arm-kernel, linux-devicetree, linux-leds, lkml
Pavel Machek [off-list ref] 於 2021年2月19日 週五 下午6:47寫道：
Hi!quoted
From: Gene Chen <redacted> Add LED_FUNCTION_MOONLIGHT definitions Signed-off-by: Gene Chen <redacted> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Acked-by: Rob Herring <robh@kernel.org>No, sorry, I don't believe we need another define for flash/torch.
As previous discuss,
We use term "Moonlight" as reference says "When you are trying to imitate moonlight you need to use low voltage, softer lighting. You don’t want something that’s too bright" which is focus on brightness instead of color.
If any concern about this change, maybe we use LED_FUNCTION_INDICATOR instead? (refs: https://lkml.org/lkml/2020/11/24/1267)
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek_______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek