Re: [PATCH v3] PCI: mediatek: Configure FC and FTS for functions other than 0
From: Krzysztof Wilczyński <hidden>
Date: 2021-02-21 19:30:04
Also in:
linux-pci
From: Krzysztof Wilczyński <hidden>
Date: 2021-02-21 19:30:04
Also in:
linux-pci
[+cc Lorenzo for visiblity] Hi, Thank you for taking care of this! [...]
PCI_FUNC(port->slot << 3)" is always 0, so previously mtk_pcie_startup_port() only configured FC credits and FTs for function 0.
[...] A small nit. The commit message is missing the opening quote, see Bjorn's suggestion: https://lore.kernel.org/linux-pci/20201104131054.GA307984@bjorn-Precision-5520/ (local) But, it's probably not worth sending another patch, and perhaps either Bjorn or Lorenzo could fix this when applying changes. Reviewed-by: Krzysztof Wilczyński <redacted> Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek