Re: [PATCH v3 14/19] crypto: qat: convert tasklets to use new tasklet_setup() API
From: Allen Pais <hidden>
Date: 2021-01-18 07:12:32
Also in:
linux-crypto, linux-rockchip, linux-samsung-soc
From: Allen Pais <hidden>
Date: 2021-01-18 07:12:32
Also in:
linux-crypto, linux-rockchip, linux-samsung-soc
quoted
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly.I have two minor comments: * Patches to the qat driver have the following headline crypto: qat - * Checkpatch reports two alignment checks when it is run with --strict: CHECK: Alignment should match open parenthesis #33: FILE: drivers/crypto/qat/qat_common/adf_isr.c:248: + tasklet_setup(&priv_data->banks[i].resp_handler, + adf_response_handler); CHECK: Alignment should match open parenthesis #62: FILE: drivers/crypto/qat/qat_common/adf_sriov.c:57: + tasklet_setup(&vf_info->vf2pf_bh_tasklet, + adf_vf2pf_bh_handler); total: 0 errors, 0 warnings, 2 checks, 83 lines checked If you prefer I can resubmit this patch with these two changes.
Thank you. I will fix them and re-submit. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek