Thread (20 messages) 20 messages, 4 authors, 2021-01-31

Re: [PATCH v4 5/8] drm/mediatek: separate ccorr module

From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2021-01-31 04:09:03
Also in: dri-devel, linux-arm-kernel, linux-devicetree, lkml

Hi, Hsin-Yi:

Hsin-Yi Wang [off-list ref] 於 2021年1月29日 週五 下午3:35寫道:
From: Yongqiang Niu <redacted>

ccorr ctm matrix bits will be different in mt8192

Signed-off-by: Yongqiang Niu <redacted>
Signed-off-by: Hsin-Yi Wang <redacted>
---
 drivers/gpu/drm/mediatek/Makefile           |   3 +-
 drivers/gpu/drm/mediatek/mtk_disp_ccorr.c   | 222 ++++++++++++++++++++
 drivers/gpu/drm/mediatek/mtk_disp_drv.h     |   9 +
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |  95 +--------
 drivers/gpu/drm/mediatek/mtk_drm_drv.c      |   8 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.h      |   1 +
 6 files changed, 242 insertions(+), 96 deletions(-)
 create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
[snip]
+
+void mtk_ccorr_config(struct device *dev, unsigned int w,
+                            unsigned int h, unsigned int vrefresh,
+                            unsigned int bpc, struct cmdq_pkt *cmdq_pkt)
+{
+       struct mtk_disp_ccorr *ccorr = dev_get_drvdata(dev);
+
+       mtk_ddp_write(cmdq_pkt, w << 16 | h, &ccorr->cmdq_reg, ccorr->regs,
+                     DISP_CCORR_SIZE);
You change w, h position here. Separate this modification to another patch.
+       mtk_ddp_write(cmdq_pkt, CCORR_ENGINE_EN, &ccorr->cmdq_reg, ccorr->regs,
+                     DISP_CCORR_CFG);
+}
+
[snip]
-static void mtk_ccorr_config(struct device *dev, unsigned int w,
-                            unsigned int h, unsigned int vrefresh,
-                            unsigned int bpc, struct cmdq_pkt *cmdq_pkt)
-{
-       struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev);
-
-       mtk_ddp_write(cmdq_pkt, h << 16 | w, &priv->cmdq_reg, priv->regs, DISP_CCORR_SIZE);
-       mtk_ddp_write(cmdq_pkt, CCORR_ENGINE_EN, &priv->cmdq_reg, priv->regs, DISP_CCORR_CFG);
-}
-
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help