RE: [PATCH v2 1/3] regulator: mt6360: Add OF match table
From: gene_chen (陳俊宇) <hidden>
Date: 2021-01-11 02:32:20
Also in:
linux-arm-kernel, lkml
[ Internal Use - External ] Hi Matthias, I discussed OF match table with Mark in previous mail in our PATCH v3, MFD should just instantiate the platform device.
Mark Brown [off-list ref] 於 2020年8月20日 週四 下午7:45寫道：
quoted
This device only exists in the context of a single parent device, there should be no need for a compatible string here - this is just a detail of how Linux does things. The MFD should just instntiate the platform device.
Trying to autoload module without of_id_table will cause run-time error: ueventd: LoadWithAliases was unable to load of:NregulatorT(null)Cmediatek,mt6360-regulator
You shouldn't have this described in the device tree at all, like I say the MFD should just instantiate the platform device.
quoted hunk ↗ jump to hunk
-----Original Message----- From: matthias.bgg@kernel.org <matthias.bgg@kernel.org> Sent: Saturday, January 9, 2021 7:26 PM To: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown [off-list ref] Cc: Hsin-Hsiung Wang <redacted>; Axel Lin [off-list ref]; Chen Zhong [off-list ref]; gene_chen(陳俊宇) [off-list ref]; linux-kernel@vger.kernel.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; Matthias Brugger [off-list ref]; Matti Vaittinen [off-list ref]; Matthias Brugger [off-list ref] Subject: [PATCH v2 1/3] regulator: mt6360: Add OF match table From: Matthias Brugger <mbrugger@suse.com> Binding documentation mentions that a compatible is required for the MT6360 device node, but the driver doesn't provide a OF match table. Fixes: d321571d5e4c ("regulator: mt6360: Add support for MT6360 regulator") Signed-off-by: Matthias Brugger <mbrugger@suse.com> --- Changes in v2: - check for CONFIG_OF - add Fixes tag drivers/regulator/mt6360-regulator.c | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/drivers/regulator/mt6360-regulator.cb/drivers/regulator/mt6360-regulator.c index 15308ee29c13..f7b2514feabf 100644--- a/drivers/regulator/mt6360-regulator.c +++ b/drivers/regulator/mt6360-regulator.c@@ -445,9 +445,18 @@ static const struct platform_device_idmt6360_regulator_id_table[] = { }; MODULE_DEVICE_TABLE(platform, mt6360_regulator_id_table); +#ifdef CONFIG_OF +static const struct of_device_id mt6360_of_match[] = { +{ .compatible = "mediatek,mt6360-regulator", }, +{ /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, mt6360_of_match); #endif + static struct platform_driver mt6360_regulator_driver = { .driver = { .name = "mt6360-regulator", +.of_match_table = of_match_ptr(mt6360_of_match), }, .probe = mt6360_regulator_probe, .id_table = mt6360_regulator_id_table, -- 2.29.2
************* Email Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek