Re: [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2
From: Richard Weinberger <hidden>
Date: 2017-06-01 19:23:49
On Thu, Jun 1, 2017 at 11:01 AM, [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Xiaolei Li <redacted> Write size in function write_eraseblock2 is subpgsize * k. It is wrong to check whether written is equal to subpgsize after each mtd_write. Signed-off-by: Xiaolei Li <redacted> --- drivers/mtd/tests/subpagetest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetest.c index aecc6ce..fa2519a 100644 --- a/drivers/mtd/tests/subpagetest.c +++ b/drivers/mtd/tests/subpagetest.c@@ -102,7 +102,7 @@ static int write_eraseblock2(int ebnum) if (unlikely(err || written != subpgsize * k)) { pr_err("error: write failed at %#llx\n", (long long)addr); - if (written != subpgsize) { + if (written != subpgsize * k) { pr_err(" write size: %#x\n", subpgsize * k); pr_err(" written: %#08zx\n",
Reviewed-by: Richard Weinberger <richard@nod.at> -- Thanks, //richard ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/