Thread (14 messages) 14 messages, 3 authors, 2016-11-07

Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release argument

From: Vincent Stehlé <hidden>
Date: 2016-10-28 07:53:03
Also in: linux-arm-kernel, linux-media, lkml

On Thu, Oct 27, 2016 at 10:23:24PM +0200, Vincent Stehlé wrote:
video_device_release() takes a pointer to struct video_device as argument.
Fix two call sites where the address of the pointer is passed instead.
Sorry, I messed up: please ignore that "fix". The 0day robot made me
realize this is indeed not a proper fix.

The issue remains, though: we cannot call video_device_release() on the
vdev structure member, as this will in turn call kfree(). Most probably,
vdev needs to be dynamically allocated, or the call to
video_device_release() dropped completely.

Sorry for the bad patch.

Best regards,

Vincent.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help