Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0
From: Sean Wang <sean.wang@mediatek.com>
Date: 2016-09-22 15:21:52
Also in:
lkml, netdev
From: Sean Wang <sean.wang@mediatek.com>
Date: 2016-09-22 15:21:52
Also in:
lkml, netdev
Date: Thu, 22 Sep 2016 14:28:36 +0300, Sergei Shtylyov [off-list ref] wrote:
Hello. On 9/22/2016 5:33 AM, sean.wang@mediatek.com wrote:quoted
From: Sean Wang <sean.wang@mediatek.com> Add the dts property for the capability if TRGMII supported on GAMC0 Signed-off-by: Sean Wang <sean.wang@mediatek.com> --- Documentation/devicetree/bindings/net/mediatek-net.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt index 6103e55..7111278 100644 --- a/Documentation/devicetree/bindings/net/mediatek-net.txt +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt@@ -31,7 +31,10 @@ Optional properties: Required properties: - compatible: Should be "mediatek,eth-mac" - reg: The number of the MAC -- phy-handle: see ethernet.txt file in the same directory. +- phy-handle: see ethernet.txt file in the same directory and + the phy-mode "trgmii" required being provided when regSince you've modified the generic parser of the "phy-mode" to add your "trgmii", you also need to update ethernet.txt...
quoted
+ is equal to 0 and the MAC uses fixed-link to connect + with inernal switch such as MT7530.Internal.
thank you for taking time and effort to review this I will fix it up