Hi Hans,

On Wed, 2016-09-14 at 13:51 +0200, Hans Verkuil wrote:

Hi Tiffany,

On 09/09/2016 05:48 PM, Tiffany Lin wrote:

quoted

Add V4L2_PIX_FMT_MT21C documentation

Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com>
---
 Documentation/media/uapi/v4l/pixfmt-reserved.rst |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst
index 0dd2f7f..0989e99 100644
--- a/Documentation/media/uapi/v4l/pixfmt-reserved.rst
+++ b/Documentation/media/uapi/v4l/pixfmt-reserved.rst

@@ -339,7 +339,17 @@ please make a proposal on the linux-media mailing list.
 	  array. Anything what's in between the UYVY lines is JPEG data and
 	  should be concatenated to form the JPEG stream.
 
+    -  .. _V4L2-PIX-FMT-MT21C:
 
+       -  ``V4L2_PIX_FMT_MT21C``
+
+       -  'MT21C'
+
+       -  Compressed two-planar YVU420 format used by Mediatek MT8173.
+          The compression is lossless.
+          It is an opaque intermediate format, and MDP HW could convert

Is it OK if I change this to:

" and the MDP hardware must be used to convert"

Yes. It's better to make it more clear how to use MT21C.
Thanks for the help.

quoted

+          V4L2_PIX_FMT_MT21C to V4L2_PIX_FMT_NV12M,
+          V4L2_PIX_FMT_YUV420M and V4L2_PIX_FMT_YVU420.

and here "and" should be replaced by "or".

Yes. it should be "or". Sorry about that.


best regards,
Tiffany

Regards,

	Hans

quoted

 
 .. tabularcolumns:: |p{6.6cm}|p{2.2cm}|p{8.7cm}|