Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function
From: CK Hu <hidden>
Date: 2016-09-07 02:34:06
Also in:
dri-devel, linux-arm-kernel, lkml
Hi, YT: On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote:
From: shaoming chen <redacted> add dsi read/write commands for transfer function Signed-off-by: shaoming chen <redacted> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++ 1 file changed, 188 insertions(+)
[snip...]
quoted hunk ↗ jump to hunk
+static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit) +{ + dsi->irq_data &= ~irq_bit; +} +
[snip...]
quoted hunk ↗ jump to hunk
+ +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag, + unsigned int timeout) +{ + s32 ret = 0; + unsigned long jiffies = msecs_to_jiffies(timeout); + + ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue, + dsi->irq_data & irq_flag, + jiffies); + if (ret == 0) { + dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag); + + mtk_dsi_enable(dsi); + mtk_dsi_reset_engine(dsi); + } + + return ret; +}
I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should be moved to the 6th patch [1] of this series because these two functions deal the irq control. [1] https://patchwork.kernel.org/patch/9310819/ Regards, CK _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel