Re: [PATCH v4 3/4] soc: mediatek: Add MT2701 power dt-bindings
From: Rob Herring <robh@kernel.org>
Date: 2016-01-20 16:35:16
Also in:
linux-arm-kernel, linux-devicetree, lkml
From: Rob Herring <robh@kernel.org>
Date: 2016-01-20 16:35:16
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Wed, Jan 20, 2016 at 05:29:21PM +0800, Yingjoe Chen wrote:
On Wed, 2016-01-20 at 14:08 +0800, James Liao wrote:quoted
From: Shunli Wang <redacted> Add power dt-bindings for MT2701. Signed-off-by: Shunli Wang <redacted> Signed-off-by: James Liao <redacted> --- .../devicetree/bindings/soc/mediatek/scpsys.txt | 6 +++-- include/dt-bindings/power/mt2701-power.h | 27 ++++++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) create mode 100644 include/dt-bindings/power/mt2701-power.hdiff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt index a6c8afc..807d87f 100644 --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt@@ -9,10 +9,12 @@ domain control. The driver implements the Generic PM domain bindings described in power/power_domain.txt. It provides the power domains defined in -include/dt-bindings/power/mt8173-power.h. +include/dt-bindings/power/mt8173-power.h and mt2701-power.h. Required properties: -- compatible: Must be "mediatek,mt8173-scpsys" +- compatible: Should be: + - "mediatek,mt8173-scpsys" + - "mediatek,mt2701-scpsys" - #power-domain-cells: Must be 1 - reg: Address range of the SCPSYS unit - infracfg: must contain a phandle to the infracfg controllerPlease sort the list.
And s/Should be/Should be one of/ Rob