Thread (5 messages) 5 messages, 2 authors, 2021-12-13

Re: [PATCH] media: vsp1: mask interrupts before enabling

From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Date: 2021-12-13 20:13:57
Also in: linux-renesas-soc, lkml

Hi.

Now I'm finally looking at this again.
I think I would rather see the code to reset them done in
vsp1_reset_wpf(), rather than in probe directly as that is what we are
doing, and is I believe already in the call path.
Could you please explain, how that is intended to be called on the probe path?

As far as can read from the code, vsp1_reset_wpf() is only called from vsp1_device_init(), which in turn 
is called only from PM resume hook and only if vsp1->info is already set. However, in the probe path, 
pm_runtime_enable() is called before vsp1->info is set.

Nikita
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help