Re: [PATCH v2] media: uvcvideo: Set the colorspace as sRGB if undefined

From
Ricardo Ribalda <hidden>
Date
2021-11-12 22:24:05
Reply to
James Hilliard, 2021-11-12
Hi James

could you check if this fixes your issue:
diff --git a/utils/v4l2-compliance/v4l2-test-controls.cpp
b/utils/v4l2-compliance/v4l2-test-controls.cpp
index a303baef560e..8731c9eb635e 100644
--- a/utils/v4l2-compliance/v4l2-test-controls.cpp
+++ b/utils/v4l2-compliance/v4l2-test-controls.cpp
@@ -851,7 +851,7 @@ int testExtendedControls(struct node *node)
                warn("s_ext_ctrls returned EILSEQ\n");
                ret = 0;
        }
-       if (ret && !multiple_classes)
+       if (ret && !(ret == EACCES && is_uvcvideo) && !multiple_classes)
                return fail("could not set all controls of a specific class\n");
        if (ret != EINVAL && multiple_classes)
                return fail("should get EINVAL when setting
mixed-class controls\n");

If so  I will prepare v4 of
https://patchwork.linuxtv.org/project/linux-media/patch/20210317143453.483470-1-ribalda@chromium.org/

Thanks!
Thread (15 messages) 15 messages, 3 authors, last reply 2021-11-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help