Thread (2 messages) 2 messages, 2 authors, 2021-08-19

Re: [PATCH] TDA1997x: fix tda1997x_query_dv_timings() return value

From: Tim Harvey <tharvey@gateworks.com>
Date: 2021-08-19 16:48:28
Also in: lkml

On Mon, Jul 26, 2021 at 3:46 AM Krzysztof Hałasa [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
index 043cc8275d00..cbfe58e413e9 100644
--- a/drivers/media/i2c/tda1997x.c
+++ b/drivers/media/i2c/tda1997x.c
@@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd,
                                     struct v4l2_dv_timings *timings)
 {
        struct tda1997x_state *state = to_state(sd);
+       int ret;

        v4l_dbg(1, debug, state->client, "%s\n", __func__);
        memset(timings, 0, sizeof(struct v4l2_dv_timings));
        mutex_lock(&state->lock);
-       tda1997x_detect_std(state, timings);
+       ret = tda1997x_detect_std(state, timings);
        mutex_unlock(&state->lock);

-       return 0;
+       return ret;
 }

 static const struct v4l2_subdev_video_ops tda1997x_video_ops = {
Krzysztof,

Patch looks good to me but needs a commit log.

Best regards,

Tim
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help