Thread (12 messages) 12 messages, 2 authors, 2021-08-03

Re: [PATCH v3 7/7] media: venus: Set buffer to FW based on FW min count requirement.

From: Stanimir Varbanov <hidden>
Date: 2021-08-03 08:00:46
Also in: linux-arm-msm, lkml


On 8/2/21 10:50 AM, dikshita@codeaurora.org wrote:
quoted
quoted
req->count_min = inst->fw_min_cnt;
+
+    ret = hfi_plat->bufreq(&params, inst->session_type, buftype, req);
+    if (buftype == HFI_BUFFER_OUTPUT || buftype == HFI_BUFFER_OUTPUT2)
^^^^
quoted
+        if (inst->fw_min_cnt != req->count_min)
+            inst->fw_min_cnt = req->count_min;
+    return ret;
 }
Also in regards to inst->fw_min_cnt, can we pass fw_min_cnt as input to
get_bufreq via 'req' structure, i.e.

req.count_min = inst->fw_min_cnt;

ret = venus_helper_get_bufreq(inst, type, &req);

inst->fw_min_cnt = req.count_min

?
Sorry, I didn't get it, How is this different from the current
implementation?
The difference is that platform_get_bufreq() will not modify any of
'struct venus_inst' members, i.e. platform_get_bufreq() is not supposed
to change anything from input 'inst' argument.

-- 
regards,
Stan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help