On 2021/6/14 13:54, Christoph Hellwig wrote:

On Sun, Jun 13, 2021 at 05:29:13PM +0800, Dongdong Liu wrote:

quoted

+static void pci_configure_10bit_tags(struct pci_dev *dev)
+{
+	struct pci_dev *bridge;
+
+	if (!pci_is_pcie(dev))
+		return;
+
+	if (!(dev->pcie_devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_COMP))
+		return;

Doesn't the second check imply the first one?

Yes, no need the first one, will delete.

Thanks,
Dongdong

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
.