Applied.  Thanks!

On Fri, May 28, 2021 at 8:18 AM Christian König
[off-list ref] wrote:

Am 28.05.21 um 11:29 schrieb Jiapeng Chong:

quoted

In the function amdgpu_uvd_cs_msg(), every branch in the switch
statement will have a return, so the code below the switch statement
will not be executed.

Eliminate the follow smatch warning:

drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:845 amdgpu_uvd_cs_msg() warn:
ignoring unreachable code.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Jiapeng Chong <redacted>

Reviewed-by: Christian König <christian.koenig@amd.com>

quoted

---
Changes in v2:
   -For the follow advice: https://lore.kernel.org/patchwork/patch/1435968/

  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
index c6dbc08..35f6874 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c

@@ -829,9 +829,8 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx,

      default:
              DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
-             return -EINVAL;
      }
-     BUG();
+
      return -EINVAL;
  }

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx