Re: [PATCH] media: uvcvideo: Remove unused variable
From: Dan Carpenter <hidden>
Date: 2021-05-03 09:29:45
Also in:
kernel-janitors
On Fri, Apr 30, 2021 at 06:18:14PM -0400, Nigel Christian wrote:
quoted hunk ↗ jump to hunk
The variable buflen is being assigned a value that is never read, which can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Nigel Christian <redacted> --- drivers/media/usb/uvc/uvc_driver.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index 9a791d8ef200..370b086c6e22 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c@@ -768,7 +768,6 @@ static int uvc_parse_format(struct uvc_device *dev, format->xfer_func = uvc_xfer_func(buffer[4]); format->ycbcr_enc = uvc_ycbcr_enc(buffer[5]); - buflen -= buffer[0]; buffer += buffer[0]; }
This is a situation where I think that the unused assignment helps readability because it shows how buflen and buffer are connected. regards, dan carpenter