Thread (22 messages) 22 messages, 3 authors, 2021-02-02

Re: [PATCH v4 11/14] media: v4l2-async: Fix incorrect comment

From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: 2021-02-02 08:45:02

Hi Helen,

Thanks for the review!

On Mon, Feb 01, 2021 at 04:33:54PM -0300, Helen Koike wrote:

On 1/28/21 9:09 AM, Sakari Ailus wrote:
quoted
From: Ezequiel Garcia <redacted>

The v4l2_async_notifier_cleanup() documentation mentions
v4l2_fwnode_reference_parse_sensor_common, which was actually
introduced as v4l2_async_notifier_parse_fwnode_sensor_common(),
in commit 7a9ec808ad46 ("media: v4l: fwnode: Add convenience function for
parsing common external refs").

The function drivers do use is
v4l2_async_register_subdev_sensor_common().

Signed-off-by: Ezequiel Garcia <redacted>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 include/media/v4l2-async.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h
index 8815e233677e..f2cac0931372 100644
--- a/include/media/v4l2-async.h
+++ b/include/media/v4l2-async.h
@@ -250,7 +250,7 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier);
  * notifier after calling
  * @v4l2_async_notifier_add_subdev,
  * @v4l2_async_notifier_parse_fwnode_endpoints or
- * @v4l2_fwnode_reference_parse_sensor_common.
+ * @v4l2_async_register_subdev_sensor_common.
This line gets removed on patch 14/14, maybe just drop this patch?
I'll squash it with 14th.

-- 
Sakari Ailus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help