Hi Andy,
On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote:
On Tue, Feb 09, 2021 at 11:20:32AM +0200, Sakari Ailus wrote:
quoted
On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote:
quoted
On Mon, Feb 8, 2021 at 10:11 PM Sakari Ailus
[off-list ref] wrote:
...
quoted
quoted
quoted
+ %p4cc BG12 little-endian (0x32314742)
This misses examples of the (strange) escaping cases and wiped
whitespaces to make sure everybody understands that 'D 12' will be the
same as 'D1 2' (side note: which I disagree on, perhaps something
should be added into documentation why).
The spaces are expected to be at the end only. I can add such example if
you like. There are no fourcc codes with spaces in the middle in neither
V4L2 nor DRM, and I don't think the expectation is to have them either.
But then the code suggests otherwise. Perhaps we need to extract
skip_trailing_spaces() from strim() and use it here.
But this wouldn't affect the result in this case, would it?
...
quoted
quoted
quoted
+static noinline_for_stack
+char *fourcc_string(char *buf, char *end, const u32 *fourcc,
+ struct printf_spec spec, const char *fmt)
+{
quoted
+ char output[sizeof("(xx)(xx)(xx)(xx) little-endian (0x01234567)")];
Do we have any evidence / document / standard that the above format is
what people would find good? From existing practices (I consider other
printings elsewhere and users in this series) I find '(xx)' form for
hex numbers is weird. The standard practice is to use \xHH (without
parentheses).
Earlier in the review it was proposed that special handling of codes below
32 should be added, which I did. Using the parentheses is apparently an
existing practice elsewhere.
Where? \xHH is quite well established format for escaping. Never heard about
'(xx)' variant before this very series.
Mauro referred to FourCC codes while reviewing an earlier version of this,
such as RGB(15).
Does \× imply only the next two characters are hexadecimal? I have to admit
I don't remember seeting that, nor \x notation is common.
quoted
Note that neither DRM nor V4L2 currently has such fourcc codes currently.
...
quoted
quoted
quoted
+ p = special_hex_number(p, output + sizeof(output) - 2, *fourcc,
+ sizeof(u32));
This is perfectly one line (in this file we have even longer lines).
Sure, you can do that, and I can then review your patch and point to the
coding style documentation. :-)
Yes, you can. The problem is that we agreed with others to improve readability
by letting some lines to be longer, so the code can lie on one line rather be
broken on two or more.
Making the end of the line invisible without scrolling vertically doesn't
improve readability for me. It does depend on window width though. I'd
simply only use that if 80 isn't enough.
--
Regards,
Sakari Ailus