Re: [PATCH 6/6] media: adv7180: fix field type

On 2016-07-29 12:32:30 -0700, Steve Longerbeam wrote:

On 07/29/2016 12:10 PM, Sergei Shtylyov wrote:

quoted

On 07/29/2016 08:40 PM, Niklas Söderlund wrote:

quoted

From: Steve Longerbeam <slongerbeam@gmail.com>

The ADV7180 and ADV7182 transmit whole fields, bottom field followed
by top (or vice-versa, depending on detected video standard). So
for chips that do not have support for explicitly setting the field
mode, set the field mode to V4L2_FIELD_ALTERNATE.

Signed-off-by: Steve Longerbeam <redacted>
[Niklas: changed filed type from V4L2_FIELD_SEQ_{TB,BT} to
V4L2_FIELD_ALTERNATE]
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Tested-by: Sergei Shtylyov <redacted>

   IIUC, it's a 4th version of this patch; you should have kept the
original change log (below --- tearline) and indicated that in the
subject.

MBR, Sergei

This version is fine with me. The i.mx6 h/w motion-compensation deinterlacer
(VDIC)
needs to know the field order, and it can't get that info from
V4L2_FIELD_ALTERNATE,
but it can still determine the order via querystd().

But I agree the change log should be preserved, and the V4L2_FIELD_ALTERNATE
change
added to the change log.

Yes, I will send a v2 containing the changelog. My bad for dropping it.

Acked-by: Steve Longerbeam <slongerbeam@gmail.com>

Steve

-- 
Regards,
Niklas Söderlund