Hi, Jonathan

-----Original Message-----
From: Jonathan Corbet [mailto:corbet@lwn.net]
Sent: Monday, 17 December, 2012 06:55
To: Albert Wang
Cc: g.liakhovetski@gmx.de; linux-media@vger.kernel.org; Libin Yang
Subject: Re: [PATCH V3 15/15] [media] marvell-ccic: add 3 frame buffers support in
DMA_CONTIG mode

On Sun, 16 Dec 2012 14:34:31 -0800
Albert Wang [off-list ref] wrote:

quoted

quoted

What is the purpose of the "usebufs" field?  The code maintains it in
various places, but I don't see anywhere that actually uses that value for
anything.

[Albert Wang] Two buffers mode doesn't need it.
But Three buffers mode need it indicates which conditions we need set the single

buffer flag.

quoted

I used "tribufs" as the name in the previous version, but it looks it's a confused name

when we merged

quoted

Two buffers mode and Three buffers mode with same code by removing #ifdef based

on your comments months ago. :)

quoted

So we just changed the name with "usebufs".

OK, I misread the code a bit, sorry.  I do find the variable confusing
still, but it clearly does play a role.

I think that using three buffers by default would make sense.  I don't
think that increased overruns are an unbreakable ABI feature :)

[Albert Wang] OK, we can change the default to three buffers mode.

Feel free to add my ack to this one.

Thanks,

jon

Thanks
Albert Wang
86-21-61092656