Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization
From: Julia Lawall <hidden>
Date: 2012-10-08 05:04:25
Also in:
kernel-janitors, lkml
On Sun, 7 Oct 2012, Joe Perches wrote:
On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote:quoted
On Sun, 7 Oct 2012, Joe Perches wrote:quoted
quoted
Are READ and WRITE the action names? They are really the important information in this case.Yes, most (all?) uses of _READ and _WRITE macros actually perform some I/O.I2C_MSG_READ_DATA? I2C_MSG_READ_INFO? I2C_MSG_READ_INIT? I2C_MSG_PREPARE_READ?Dunno, naming is hard. Maybe: I2C_INPUT_MSG I2C_OUTPUT_MSG I2C_OP_MSG
The current terminology, however, is READ, not INPUT (.flags = I2C_M_RD). julia