Re: [PULL] soc-camera for 3.3
From: Guennadi Liakhovetski <hidden>
Date: 2012-01-02 08:20:59
Hi Javier On Mon, 2 Jan 2012, javier Martin wrote:
Hi Guennadi, On 29 December 2011 09:38, Guennadi Liakhovetski [off-list ref] wrote:quoted
Hi Mauro Please pull a couple of soc-camera patches for 3.3. This is going to be a _much_ quieter pull, than the previous one:-) I didn't have time to continue the work on the soc-camera Media Controller conversion, so, that will have to wait at least until 3.4. Interestingly, Javier Martin has fixed field_count handling in mx2_camera, but, apparently, it also has to be fixed in other soc-camera drivers. So, a patch for that might follow later in the 3.3 cycle. The following changes since commit 1a5cd29631a6b75e49e6ad8a770ab9d69cda0fa2: [media] tda10021: Add support for DVB-C Annex C (2011-12-20 14:01:08 -0200) are available in the git repository at: git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.3 Guennadi Liakhovetski (4): V4L: soc-camera: remove redundant parameter from the .set_bus_param() method V4L: mt9m111: cleanly separate register contexts V4L: mt9m111: power down most circuits when suspended V4L: mt9m111: properly implement .s_crop and .s_fmt(), reset on STREAMON Javier Martin (2): media i.MX27 camera: add support for YUV420 format. media i.MX27 camera: Fix field_count handling.So, you already applied my patch related to "field_count" handling. I was preparing a v3 for that patch to fix the frame_count type issue and to really provide frame loss detection but I can prepare it on top of the old one if you want.
Yes, the type issue is not that severe. Matching a type of another variable or a struct field, with which this variable is connected, is a valid reason, so, we can keep u32, if you like. As for frame loss detection - yes, please, provide it as an incremental patch. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/