Thread (33 messages) 33 messages, 6 authors, 2011-03-18

Re: [PATCH 05/16] [media] ec168: get rid of on stack dma buffers

From: Florian Mickler <hidden>
Date: 2011-03-18 21:33:43
Also in: lkml

On Fri, 18 Mar 2011 18:36:53 +0200
Antti Palosaari [off-list ref] wrote:
On 03/15/2011 10:43 AM, Florian Mickler wrote:
quoted
usb_control_msg initiates (and waits for completion of) a dma transfer using
the supplied buffer. That buffer thus has to be seperately allocated on
the heap.

In lib/dma_debug.c the function check_for_stack even warns about it:
	WARNING: at lib/dma-debug.c:866 check_for_stack

Note: This change is tested to compile only, as I don't have the hardware.

Signed-off-by: Florian Mickler<redacted>
Acked-by: Antti Palosaari <redacted>
Reviewed-by: Antti Palosaari <redacted>
Tested-by: Antti Palosaari <redacted>

t. Antti
Thanks for the feedback!

Regards,
Flo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help