Thread (6 messages) 6 messages, 3 authors, 2025-11-24

Re: [Patch v2 0/1] man/man2/ioctl_vt.2: Various improvements.

From: Alejandro Colomar <alx@kernel.org>
Date: 2025-11-24 16:17:03

Hi Teika,
Subject: Re: [Patch v2 0/1] man/man2/ioctl_vt.2: Various improvements.
Please send improvements one-by-one, in small patches that do one thing
and do it well.  I generally dislike patches that do "various
improvements".  "various improvements" is only a decent title for a
patch set, but not for a patch.

On Fri, Nov 14, 2025 at 09:31:02PM +0900, Teika Kazura wrote:
Some follow-ups.

1.
From: Jakub Wilk <redacted>
quoted
VT_GETHIFONTMASK is documented in vcs(4).
[...]
s/exapmle/example/
Thanks. I checked the other 4 undocumented calls are not documented elsewhere
in man-pages.

2.
In the v2 patch,
a) The markup of "See also" at the bottom is wrong. 
Please send a separate patch to address that.
b) "privilege of CAP_SYS_TTY_CONFIG" -> capability of
Please send a separate patch to address that.
3.
I'm thinking of adding something like below. It might be too wordy,
and not exactly for a man-page, but I think it is better than
being completely lacking. Any comment?
------------------------------------------------------------------------
VT_WAITEVENT: This is implemented, but do not use.

Historical note: In 2010, by the request of the package ConsoleKit, VT_WAITEVENT was implemented. However it turned out to be a failure, and ConsoleKit gave up its use. This ioctl is a mere relic.
https://bugs.freedesktop.org/show_bug.cgi?id=17720

VT_RELDISP: 
(Add this) The package elogind does ignore acquistion event.  
https://raw.githubusercontent.com/elogind/elogind/refs/heads/main/src/login/logind.c

-----------------------------------------------------------------------
Anyway if it's to be rejected, I'll post it to bugzilla for slightly better searchabitily. It's an abuse of bugzilla, but I don't care. :p
You can send a patch.  We can discuss any wording.  As you said, some
documentation is better than no documentation.


Have a lovely day!
Alex
4.
I'll add VT_LOCKSWITCH and VT_UNLOCKSWITCH too. They are simply what the names suggests.

Teika
-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help