Hi Mingye,

On Mon, Nov 10, 2025 at 11:51:30AM +0800, Mingye Wang wrote:

On Mon, Nov 10, 2025 at 11:05 AM Mingye Wang [off-list ref] wrote:

quoted

quoted

Does /dev/urandom block when reading with read(2) before the pool is

ready?  I assume it blocks.

From what I've heard it does not. Working on other comments.

Done working on the review comments, but git send-email is not working
for me again (it accepts no proxy settings and tunnels are flakey;
worse, it doesn't save my multi-sentence edited heading, or my
in-reply to string which I need to copy again, or the recipient
list...). I apologize but I am sending it as an attachment.

This might be helpful:

	$ cat CONTRIBUTING.d/git | sed -n '/^   git-send-email/,+9p'
	   git-send-email(1)
	       If mutt(1) or neomutt(1) are configured in the system,
	       git-send-email(1) can be configured to use any of them as a
	       driver.  Recent versions of neomutt(1) can enable crypto with -C.

		   $ git config --global \
			   sendemail.sendmailcmd 'neomutt -C -H - && true';
	       or
		   $ git config --global sendemail.sendmailcmd 'mutt -H - && true';

That's what I use to sign my email containing patches.  I use
git-send-email(1) on the command line, but it calls neomutt(1) for the
actual sending.  If you use mutt(1) or neomutt(1), you could do this.

I am sending only the revised version of the patch you commented on
(the one that touches three files, random.{4,7}, getrandom.2). You
might notice that this patch is much larger. This is because when
editing the table I noticed that there's really no reason to keep the
"Pool" column around for 5.6+, but removing it also felt off. In the
end I just made two separate tables, but with identical cell-width
settings.

I'd prefer that change in a separate patch.  I'll confirm when I see
the patch, but in general, I'd like to avoid putting actual changes with
formatting changes in the same commit, unless they're somehow tied
together for a good reason.

Speaking of cell-width settings, the existing version was not filling
the entire screen, which contravenes what man-pages(7) says about
using lbx. Adding an "x" does make it look nicer too.

Okay.  Although I'd prefer that as a separate patch.

(I have no idea whether this is the fourth version, but it's
definitely after the third and five seems too many. In any case, I
will be incrementing this number in future patch submissions to keep
things navigable.)

Okay, that's fine.

Regards,
Mingye Wang (Artoria2e5)

Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).