On 2025-10-01, Alejandro Colomar [off-list ref] wrote:

Hi Askar,

On Wed, Oct 01, 2025 at 03:38:41AM +0300, Askar Safin wrote:

quoted

Aleksa Sarai [off-list ref]:

quoted

+mntfd2 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
+                   &attr, sizeof(attr));

Your whole so-called "open_tree_attr example" doesn't contain any open_tree_attr
calls. :)

I think you meant open_tree_attr here.

I'll wait for Aleksa to confirm before applying and amending.

Yeah, Askar is right, they were a copy-paste snafu.

quoted

quoted

+\&
+/* Create a new copy with the id-mapping cleared */
+memset(&attr, 0, sizeof(attr));
+attr.attr_clr = MOUNT_ATTR_IDMAP;
+mntfd3 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
+                   &attr, sizeof(attr));

And here.

Otherwise your whole patchset looks good. Add to whole patchset:
Reviewed-by: Askar Safin <redacted>

Thanks!  I'll retro-fit that to the commits I've aplied already too, as
I haven't pushed them to master yet.


Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>
Use port 80 (that is, <...:80/>).

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/