Thread (36 messages) 36 messages, 5 authors, 2025-08-09

Re: [PATCH v2 08/11] open_tree.2: document 'new' mount api

From: Aleksa Sarai <hidden>
Date: 2025-08-08 13:27:15
Also in: linux-api, linux-fsdevel, lkml

On 2025-08-08, Askar Safin [off-list ref] wrote:
In "man open_tree":
quoted
As with "*at()" system calls, fspick() uses the dirfd argument in conjunction
You meant "open_tree"
quoted
If flags does not contain OPEN_TREE_CLONE, open_tree() returns
a file descriptor that is exactly equivalent to one produced by open(2).
Please, change "by open(2)" to "by openat(2) with O_PATH" (and other similar places).
I think the more common pattern in man-pages is to prefer to refer to
open(2) unless you are explicitly talking about openat(2) features (like
passing a dirfd). If it's just "a file descriptor with O_PATH" then most
man-pages I've seen reference open(2) even if they were written
post-openat(2).

Though in this case, since we are talking about open_tree(2) as an open
operation that takes a dirfd, you're right that openat(2) might be
better.

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help