Re: [PATCH] man/man1/iconv.1: Mention that -c does not change exit status
From: Carlos O'Donell <hidden>
Date: 2025-06-05 14:42:04
On 6/5/25 8:46 AM, Florian Weimer wrote:
And that input decoding failures are treated as errors. Exiting with status 0 is a POSIX conformance issue that was fixed in glibc 2.41. Signed-off-by: Florian Weimer <redacted>
Confirmed 6cbf845fcdc76131d0e674cee454fe738b69c69d is the correct glibc git commit for this fix. Confirmed it was fixed in glibc 2.41 along with several other iconv fixes. Confirmed issue 8 contains the same language for -c and exit status must not change. Reviewed-by: Carlos O'Donell <redacted>
quoted hunk ↗ jump to hunk
--- man/man1/iconv.1 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)diff --git a/man/man1/iconv.1 b/man/man1/iconv.1 index 2c8ae0d29..111ff9e89 100644 --- a/man/man1/iconv.1 +++ b/man/man1/iconv.1@@ -55,6 +55,8 @@ is appended to .IR to-encoding , characters that cannot be converted are discarded and an error is printed after conversion. +(Characters that cannot be decoded are treated as an error with +or without this flag.) .IP If the string .B //TRANSLIT@@ -73,8 +75,11 @@ transliterated are replaced with a question mark (?) in the output. List all known character set encodings. .TP .B \-c -Silently discard characters that cannot be converted instead of +Discard characters that cannot be converted instead of terminating when encountering such characters. +.\" glibc commit 6cbf845fcdc76131d0e674cee454fe738b69c69d +POSIX requires that this option does not change +the exit status of the program. .TP .BI \-\-output= outputfile .TQbase-commit: 3c2e9ebe2d5ea15a47c1669f75b280cea42a6f8b
-- Cheers, Carlos.