Re: [PATCH 1/2] UFFDIO_API.2const: Update userfaultfd handshake and feature probe
From: Peter Xu <peterx@redhat.com>
Date: 2025-05-14 17:21:24
Also in:
linux-mm, lkml
From: Peter Xu <peterx@redhat.com>
Date: 2025-05-14 17:21:24
Also in:
linux-mm, lkml
On Wed, May 14, 2025 at 05:59:48PM +0200, Alejandro Colomar wrote:
quoted
+.P +For historical reasons, +a temporary userfaultfd is needed to probe +what userfaultfd features the kernel supports. +The application needs to create a temporary userfaultfd, +issue an +.B UFFDIO_API +ioctl with +.I features +set to 0. After thePlease use semantic newlines. Break the line after the '.'.
This one was overlooked indeed, will fix it.
$ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p'
Use semantic newlines
In the source of a manual page, new sentences should be started
on new lines, long sentences should be split into lines at
clause breaks (commas, semicolons, colons, and so on), and long
clauses should be split at phrase boundaries. This convention,
sometimes known as "semantic newlines", makes it easier to see
the effect of patches, which often operate at the level of indi‐
vidual sentences, clauses, or phrases.
Also, please say "zero" instead of "0", as was in the old paragraph.
That will allow git-diff(1) --color-moved to detect some movement of
text.This was not part of the old text, but sure, will do. Thanks, -- Peter Xu