Thread (10 messages) 10 messages, 2 authors, 2025-05-31

Re: [PATCH v2] man/: Fix name of vm.hugetlb_shm_group

From: Alejandro Colomar <alx@kernel.org>
Date: 2025-05-31 20:41:13

Hi наб,

On Sat, May 31, 2025 at 07:58:30PM +0200, наб wrote:
On Sat, May 31, 2025 at 07:44:12PM +0200, Alejandro Colomar wrote:
quoted
quoted
Fixes: 090fdddb4 ("memfd_create.2, mmap.2, shmget.2: Document the EPERM for huge page allocations")
Fixes: 6cee0ddeb ("proc.5: Document /proc/sys/vm/sysctl_hugetlb_shm_group")
Please use 12 characters for the hash, and include the commit date in
commit references.
ftr I re-used the format from 6a949e9b08fd1ad4e77584276b9566e45fc07a93;
Yeah, I sometimes forget to complain or amend myself.  :)
the Fixes:es from git llog | grep -m100 Fixes: | uniq
Hmmm, I see some interesting pattern.  The first commit in which I used
that syntax was

	$ git log | grep ^....Fixes: | grep '(....-..-..' | tail -n1
	    Fixes: ba687b00ecb3 (2023-07-30, "man3/: srcfix")
	$ git log --grep 'Fixes: ba687b00ecb3 (2023-07-30, "man3/: srcfix")' --oneline
	842a69c6a man/man3/isalpha.3: tfix
	$ git ref 842a69c6a
	842a69c6a594 (2024-12-11; "man/man3/isalpha.3: tfix")

and since then it seems I've been quite consistent, with only a few
exceptions:

$ git log 842a69c6a594^..master | grep '^    Fixes:'
    Fixes: d7dec35a3b19 ("man/man2/ioctl_userfaultfd.2, man/man2const/UFFDIO_MOVE.2const: Document UFFDIO_MOVE")
    Fixes: a252b3345 ("ioctl_userfaultfd.2: Describe two-step feature handshake")
    Fixes: 336bd62ba24c (2021-03-21; "close_range.2: Include a better example program")
    Fixes: bb8164dec0c4 (2020-10-22; "slist.3: ffix: Use man markup")
    Fixes: 18e7c4597c4e (2024-11-17; "man/: Terminology consistency reforms (n, size, length)")
    Fixes: d2c2db8830f8 (2025-03-14; "man/: SYNOPSIS: Use GNU forward-declarations of parameters for sizes of array parameters")
    Fixes: 2904e040ded2 (2025-02-02; "man/man2/mkdir.2: ERRORS: Add EOVERFLOW")
    Fixes: 76f12e3fd3ea (2025-02-10; "share/mk/: Escape '#' in regexes")
    Fixes: 906ab4945cd3 (2021-08-20; "mount_namespaces.7: Rewrite locked mounts examples to use/etc/shadow")
    Fixes: 0d69e51cd4b8 (2025-02-10; "share/mk/: Use ?= assignments for user-facing variables")
    Fixes: 35a780a99bd8 (2024-07-20; "share/mk/: CPPFLAGS: Only define _FORTIFY_SOURCE if it's not already defined")
    Fixes: 2130162900ab (2024-11-03; "share/mk/, etc/shellcheck/: lint-sh: Add target to lint shell scripts")
    Fixes: 7bda5119fe5e (2024-09-08; "timespec_get.3, timespec_getres.3: Add page and link page")
    Fixes: b42296e4feaf (2022-09-15; "Various pages: EXAMPLES: Use unsigned types for loop iterators")
    Fixes: 07c3768e9db8 (2023-08-15; "proc.5, proc_pid_limits.5: Split /proc/PID/limits from proc(5)")
    Fixes: 8c74a1cea495 (2016-07-07; "user_namespaces.7: Clarify details of CAP_SYS_ADMIN and cgroup v1 mounts")
    Fixes: f2dfd79facf0 (2024-12-13, "src/bin/diffman: Add default case")
    Fixes: ef53ef760638 (2024-12-18, "man/man3/getline.3: Clarify ERRORS")
    Fixes: ba687b00ecb3 (2023-07-30, "man3/: srcfix")

I should try to avoid those mistakes, though.

Another thing is that I originally started with a ',' but then switched
to ';' as the separator, because I prefer to keep the comma to separate
the author date from the commit date when I print both with my ref2
alias:

	ref2 = show --no-patch --abbrev=12 --date=short \
		--format=tformat:'%C(auto)%h%C(reset) %C(dim white)(%ad, %cd%x3B \"%C(reset)%C(auto)%s%C(reset)%C(dim white)\")%C(reset)'

$ git ref2 master^
8bc318c60ffe (2025-05-18, 2025-05-21; "man/man3/*printf.3: Document ERRORS")
vary widely and most don't have a date either.

Have a lovely night!
Alex

-- 
<https://www.alejandro-colomar.es/>

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help