On Wed, Apr 2, 2025 at 10:54 PM Alejandro Colomar [off-list ref] wrote:

Hi Amir,

On Mon, Mar 31, 2025 at 03:39:58PM +0200, Amir Goldstein wrote:

quoted

FAN_EVENT_INFO_TYPE_ERROR was missing from the list of info types.

The order of FAN_FS_ERROR entry in the event section was rather
arbitrary inside the group of fid info events.

FAN_FS_ERROR is a special event with error info, so place its entry
after the entries for fid info events and before the entries for
permission events.

Reduce unneeded newlines in the FAN_FS_ERROR entry.

Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---

Alejandro,

This unrelated cleanup was plit out of the FAN_PRE_ACCESS
patch and I have also added some extra cleanup in preparation for
adding mount events.

If you were going to re-organize the section describing the different
extra event info types, maybe better doing this after merging the new
types from v6.14: FAN_EVENT_INFO_TYPE_RANGE and FAN_EVENT_INFO_TYPE_MNT.

Thanks,
Amir.

 man/man2/fanotify_mark.2 | 44 +++++++++++++++++++---------------------
 man/man7/fanotify.7      |  7 ++++---
 2 files changed, 25 insertions(+), 26 deletions(-)

diff --git a/man/man2/fanotify_mark.2 b/man/man2/fanotify_mark.2
index 47cafb21c..1d132fa1a 100644
--- a/man/man2/fanotify_mark.2
+++ b/man/man2/fanotify_mark.2

@@ -362,29 +362,6 @@ Create an event when a marked file or directory itself is deleted.
 An fanotify group that identifies filesystem objects by file handles
 is required.
 .TP
-.BR FAN_FS_ERROR " (since Linux 5.16, 5.15.154, and 5.10.220)"
-.\" commit 9709bd548f11a092d124698118013f66e1740f9b
-Create an event when a filesystem error
-leading to inconsistent filesystem metadata is detected.
-An additional information record of type
-.B FAN_EVENT_INFO_TYPE_ERROR
-is returned for each event in the read buffer.
-An fanotify group that identifies filesystem objects by file handles
-is required.
-.IP

You forgot the .IP in the moved text.

I wrote "Reduce unneeded newlines in the FAN_FS_ERROR entry."
The newlines seem unneeded IMO and inconsistent with other
entries.

But it's not a big deal.

Thanks,
Amir.