Re: [PATCH] mremap.2: Update information about MREMAP_DONTUNMAP restrictions
From: Alex Henrie <hidden>
Date: 2024-11-11 06:07:01
Also in:
linux-mm
On Tue, Nov 5, 2024 at 4:50 AM Alejandro Colomar [off-list ref] wrote:
Hi Alex,
Bon dia Alejandro, és un plaer parlar amb tu de nou!
On Mon, Nov 04, 2024 at 09:16:41PM GMT, Alex Henrie wrote:
quoted
diff --git a/man/man2/mremap.2 b/man/man2/mremap.2 index 53e0bcf2d..b99ab9492 100644 --- a/man/man2/mremap.2 +++ b/man/man2/mremap.2@@ -106,7 +106,13 @@ remaps a mapping to a new address but does not unmap the mapping at .IP The .B MREMAP_DONTUNMAP -flag can be used only with private anonymous mappings +flag can only be used with mappings that are notI find the position of "only" a bit inconsistent here. It probably would be more appropriate right before "with". (I'm wondering if I put "probably" in the right place too... :)
It probably is slightly more clear to say "can be used only with..." instead of "can only be used with...". I'll make that change in v2.
quoted
+.BR VM_DONTEXPANDPlease use .B, not .BR. You'll find that BR causes a warning in that file, if you run `make build-all`: $ make build-all -j24 -k TROFF .tmp/man/man2/mremap.2.cat.set an.tmac:.tmp/man/man2/mremap.2:42: style: .BR expects at least 2 arguments, got 1 make: *** [/home/alx/src/linux/man-pages/man-pages/contrib/share/mk/build/catman/troff.mk:65: .tmp/man/man2/mremap.2.cat.set] Error 1 make: *** Deleting file '.tmp/man/man2/mremap.2.cat.set' make: Target 'build-all' not remade because of errors. (You'll need to run a sufficiently recent system that includes groff-1.23.0, such as Debian Sid.)
Will do, thanks for the tip. -Alex