Re: [PATCH v3 2/2] landlock.7: Document Landlock ABI version 5 (IOCTL)
From: Alejandro Colomar <alx@kernel.org>
Date: 2024-07-31 11:58:22
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Alejandro Colomar <alx@kernel.org>
Date: 2024-07-31 11:58:22
Hi Günther! On Wed, Jul 31, 2024 at 01:40:54PM GMT, Günther Noack wrote:
Hello Alejandro! On Wed, Jul 31, 2024 at 12:58:51PM +0200, Alejandro Colomar wrote:quoted
On Tue, Jul 23, 2024 at 10:19:17AM GMT, Günther Noack wrote:quoted
Landlock ABI 5 restricts ioctl(2) on device files. Closes: <https://github.com/landlock-lsm/linux/issues/39> Reviewed-by: Mickaël Salaün <mic@digikod.net> Signed-off-by: Günther Noack <gnoack@google.com> ---I've applied both patches; thanks! For the moment, they're here: <https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/log/?h=contrib>Ah, thanks, I did not realize you had a separate cgit running there. These patches look good. 👍
Yup; I use it both as a staging area, and as a backup of patches to several projects. :)
quoted
Did you not add a CC tag for Konstantin on purpose on this patch, or did you forget? Should I add it?It's fine as is.
Thanks.
I CC'd Konstantin on the first patch, because he authored the networking features, and their kernel documentation, which are being turned into man pages there. He was not involved in the IOCTL feature, so on that patch he is not CC'd (but can happily comment, if interested). Konstantin: I would still appreciate if you could have a look and sign-off on the networking documentation patch as well, since you are the original author of much of that documentation on the kernel side.
I'll leave it for a few more days there, to allow Konstantin to review it; I'll push to master in a week or so. Cheers, Alex
Thanks, —Günther
-- <https://www.alejandro-colomar.es/>