Re: [PATCH 1/6] proc_pid_io.5: stats include children
From: Alejandro Colomar <alx@kernel.org>
Date: 2024-03-14 16:19:42
Hi наб, On Wed, Mar 13, 2024 at 03:26:44PM +0100, наб wrote:
This file is like getrusage(2) RUSAGE_SELF + RUSAGE_CHILDREN, the current wording implies it's like just RUSAGE_SELF. Compare:
[...] LGTM.
quoted hunk ↗ jump to hunk
Signed-off-by: Ahelenia Ziemiańska <redacted> --- man5/proc_pid_io.5 | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)diff --git a/man5/proc_pid_io.5 b/man5/proc_pid_io.5 index 124252319..81cfdd249 100644 --- a/man5/proc_pid_io.5 +++ b/man5/proc_pid_io.5@@ -11,7 +11,7 @@ .SH DESCRIPTION .TP .IR /proc/ pid /io " (since Linux 2.6.20)" .\" commit 7c3ab7381e79dfc7db14a67c6f4f3285664e1ec2 -This file contains I/O statistics for the process, for example: +This file contains I/O statistics for the process and its waited-for children, for example:
Please use semantic newlines. Maybe after 'statistics'? And then also after the comma. Do a similar thing in the hunks below. Have a lovely day! Alex
quoted hunk ↗ jump to hunk
.IP .in +4n .EX@@ -30,7 +30,7 @@ .SH DESCRIPTION .RS .TP .IR rchar ": characters read" -The number of bytes which this task has caused to be read from storage. +The number of bytes which this task and its waited-for children have caused to be read from storage. This is simply the sum of bytes which this process passed to .BR read (2) and similar system calls.@@ -40,7 +40,7 @@ .SH DESCRIPTION pagecache). .TP .IR wchar ": characters written" -The number of bytes which this task has caused, or shall cause to be written +The number of bytes which this task and its waited-for children has caused, or shall cause to be written to disk. Similar caveats apply here as with .IR rchar .@@ -60,12 +60,12 @@ .SH DESCRIPTION .BR pwrite (2). .TP .IR read_bytes ": bytes read" -Attempt to count the number of bytes which this process really did cause to +Attempt to count the number of bytes which this process and its waited-for children really did cause to be fetched from the storage layer. This is accurate for block-backed filesystems. .TP .IR write_bytes ": bytes written" -Attempt to count the number of bytes which this process caused to be sent to +Attempt to count the number of bytes which this process and its waited-for children caused to be sent to the storage layer. .TP .IR cancelled_write_bytes :@@ -73,7 +73,7 @@ .SH DESCRIPTION If a process writes 1 MB to a file and then deletes the file, it will in fact perform no writeout. But it will have been accounted as having caused 1 MB of write. -In other words: this field represents the number of bytes which this process +In other words: this field represents the number of bytes which this process and its waited-for children caused to not happen, by truncating pagecache. A task can cause "negative" I/O too. If this task truncates some dirty pagecache,-- 2.39.2
-- <https://www.alejandro-colomar.es/>
Attachments
- signature.asc [application/pgp-signature] 833 bytes