Thread (4 messages) 4 messages, 3 authors, 2021-08-31

cfsetispeed and zero baudrate

From: Pali Rohár <pali@kernel.org>
Date: 2021-08-30 10:39:00

Hello Alejandro!

Currently in cfsetispeed() documentation is written:

  If the input baud rate is set to zero, the input baud rate will be
  equal to the output baud rate.

There is B0 constant which represents "zero baud rate". And also
information that argument for cfsetispeed() (and also cfsetospeed())
must be Bnnn constant.

But above quote documents special handling, "zero" here is really
integer 0 and not pre-defined constant B0.

I think that phrase "If the input baud rate is set to zero" could be
confusing, as based on requirement to use Bnnn constants somebody could
interpret that "zero" as B0.

What do you think, should be above documentation part extended to
express that "zero" is really integer 0 and not constant B0?

Some references:
* glibc really checks for integer 0:
  https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/speed.c;h=daac5ecde1f3695b8cb178002e8756895406087b;hb=HEAD#l86
* POSIX describes that it is integer 0:
  https://pubs.opengroup.org/onlinepubs/9699919799/functions/tcsetattr.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help