On Mon, Jun 26, 2017 at 07:55:27AM -0600, Jens Axboe wrote:

On 06/26/2017 03:51 AM, Christoph Hellwig wrote:

quoted

Please document the userspace API (added linux-api and linux-man
to CC for sugestions), especially including the odd effects of the
per-inode settings.

Of course, I'll send in a diff for the fcntl(2) man page.

quoted

Also I would highly recommend to use different fcntl commands
for the file vs inode hints to avoid any strange behavior.

OK, used to have that too... I can add specific _FILE versions.

While you're at it, can you also send in an xfstest or two to check the
basic functionality of the fcntl so that we know the code reflects the
userspace API ("I set this hint and now I can query it back" and "file
hint overrides inode hint") that we want?

--D

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html