Re: [PATCH net-next v4 04/15] mctp: Add sockaddr_mctp to uapi
From: Eugene Syromiatnikov <hidden>
Date: 2021-10-14 18:35:09
Also in:
netdev
On Thu, Jul 29, 2021 at 10:20:42AM +0800, Jeremy Kerr wrote:
This change introduces the user-visible MCTP header, containing the protocol-specific addressing definitions.
[...]
quoted hunk
--- a/include/uapi/linux/mctp.h +++ b/include/uapi/linux/mctp.h@@ -9,7 +9,28 @@ #ifndef __UAPI_MCTP_H #define __UAPI_MCTP_H +#include <linux/types.h> + +typedef __u8 mctp_eid_t; + +struct mctp_addr { + mctp_eid_t s_addr; +}; + struct sockaddr_mctp { + unsigned short int smctp_family;
This gap makes the size of struct sockaddr_mctp 2 bytes less at least on m68k, are you fine with that?
+ int smctp_network; + struct mctp_addr smctp_addr; + __u8 smctp_type; + __u8 smctp_tag; };