Thread (16 messages) 16 messages, 4 authors, 2021-10-13

Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2021-09-27 17:20:16

On 2021-09-27 17:44:51 [+0200], Pavel Machek wrote:
Would you mind reading and responding to the rest of the email?
The patch you mentioned,
  https://https://lkml.kernel.org/r/.kernel.org/all/20210915181601.99a68f5718be.I1a28b342d2d52cdeeeb81ecd6020c25cbf1dbfc0@changeid/

would remove the lock from led_trigger_event().
Are there any guarantees how many callbacks maybe invoked and what kind
of locks may be acquired?
Leaving kworker usage aside there are still things like spinlock_t usage
in input_leds_brightness_set(), nic78bx_brightness_set() (from a quick
grep) which have the same problems.
I'm not applying this.
I hope you reconsider. It is not all LED usage, just the CPU trigger.
								Pavel
Sebastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help