Re: [PATCH 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers.
From: Roderick Colenbrander <hidden>
Date: 2021-09-01 20:24:49
Also in:
linux-input
Hi Pavel, On Tue, Aug 31, 2021 at 10:19 PM Pavel Machek [off-list ref] wrote:
Hi!quoted
quoted
Do you have any recommendations on what would be an appropriate function string for player indicator LEDs? Would some variant such as: "status-x" "player-status-x" "indicator-x" "player-indicator-x" be more suitable? It looks like the string "status" has been used for other existing LED names.I guess "player-x" would be suitable.quoted
quoted
I think we are pretty happy to use whatever naming scheme fits the standards of the led subsystem's userspace api for the Nintendo/Sony HID drivers, and any future game controller drivers featuring player LEDs could conform to that going forward.Pavel, could you please take a look here, so that we can proceed with the patchset?So... leds tree has just been merged:quoted
git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/tags/leds-5.15-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a998a62be9cdb509491731ffe81575aa09943a32 It includes Documentation/leds/well-known-leds.txt file. Could a section describing proposed naming be added there (both device and function), with explanations what the LEDs do?
Sure let me write add a few lines for that file and resubmit. I guess I should rebase based on Linus his tree then.. let me quickly start on that. (I'm technically on vacation and far from home, but luckily caught this and happen to have a break) Thanks, Roderick