Thread (37 messages) 37 messages, 5 authors, 2021-09-14

Re: [PATCH v2 09/15] leds: trigger: blkdev: Check devices for activity and blink LEDs

From: Ian Pilcher <hidden>
Date: 2021-09-10 15:09:13
Also in: linux-block, lkml

On 9/9/21 9:17 PM, Marek Behún wrote:
So your code allows me to use a partition block device (like sda2) to
register with the blkdev LED trigger, but when I do this, the code will
disregard that I just want the LED to blink on activity on that one
partition. Instead you will blink for whole sda, since you are looking
at stats of only part0.

Am I right?
You can't add partitions, only whole devices.

# echo vda2 > link_device
-bash: echo: write error: No such device

static int blkdev_match_name(struct device *const dev, const void *const 
name)
{
	return dev->type == &disk_type
			&& sysfs_streq(dev_to_disk(dev)->disk_name, name);
}

Partitions fail the dev->type == &disk_type check.

-- 
========================================================================
                  In Soviet Russia, Google searches you!
========================================================================
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help