Re: [PATCH] leds: flash: Remove redundant initialization of variable ret
From: Colin Ian King <hidden>
Date: 2021-08-16 07:57:42
Also in:
kernel-janitors, lkml
On 16/08/2021 07:51, Pavel Machek wrote:
Hi!quoted
From: Colin Ian King <redacted> The variable ret is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <redacted>I did this instead; hopefully that's okay with everyone. Best regards, Pavel
Thanks, looks good to me. Colin
quoted hunk ↗ jump to hunk
commit 654933ae7d32f278eecd0bb0f175785574ac4775 Author: Pavel Machek [off-list ref] Date: Mon Aug 16 08:47:08 2021 +0200 leds: flash: Remove redundant initialization of variable ret Adjust initialization not to trigger Coverity warnings. Reported-by: Colin Ian King [off-list ref] Signed-off-by: Pavel Machek [off-list ref]diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c index 6eeb9effcf65..185e17055317 100644 --- a/drivers/leds/led-class-flash.c +++ b/drivers/leds/led-class-flash.c@@ -92,14 +92,12 @@ static ssize_t flash_strobe_store(struct device *dev, struct led_classdev *led_cdev = dev_get_drvdata(dev); struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev); unsigned long state; - ssize_t ret = -EINVAL; + ssize_t ret = -EBUSY; mutex_lock(&led_cdev->led_access); - if (led_sysfs_is_disabled(led_cdev)) { - ret = -EBUSY; + if (led_sysfs_is_disabled(led_cdev)) goto unlock; - } ret = kstrtoul(buf, 10, &state); if (ret)