Hi Marek,

On Wed, Aug 11, 2021 at 12:48 PM Marek Behún [off-list ref] wrote:

On Wed, 11 Aug 2021 11:57:59 +0200
Geert Uytterhoeven [off-list ref] wrote:

quoted

Instantiate a single LED based on the "led" subnode in DT.
This allows the user to control display brightness and blinking (backed
by hardware support) through the LED class API and triggers, and exposes
the display color.  The LED will be named
"auxdisplay:<color>:<function>".

When running in dot-matrix mode and if no "led" subnode is found, the
driver falls back to the traditional backlight mode, to preserve
backwards compatibility.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Reviewed-by: Marek Behún <kabel@kernel.org>

Thanks!

BTW, this driver does not need to depend on OF, methinks.
The few instances of properties reading can be
easily rewritten to device_* functions (from include/linux/property.h).
The of_get_child_by_name() can become device_get_named_child_node().

Geert, what do you think?

Sure, that can be done later, when an ACPI user appears?
The dependency on OF was pre-existing, and this series is already
at v5.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds