Thread (25 messages) 25 messages, 6 authors, 2021-07-30

Re: [RFC PATCH 1/8] docs: Add block device LED trigger documentation

From: Ian Pilcher <hidden>
Date: 2021-07-29 15:52:14
Also in: kernelnewbies, linux-block, lkml

On 7/28/21 10:09 PM, Valdis Klētnieks wrote:
quoted
+	# cat /sys/class/block/led_trigger_list
+	baz: 0
+	bar: 0
+	foo: 0
This looks like an abuse of the "one entry one value" rule for sysfs.
Perhaps this should be a directory /sys/class/block/defined_triggers/
and separate files under that for foo, bar, and baz?  That would probably
make reference counting a lot easier as well....
Indeed it is.

Funny that you should mention using a subdirectory.  I originally wanted
to put all of the trigger-related stuff into
/sys/class/block/led_triggers/, but I couldn't find any API to create a
subdirectory for *class* attributes (only for device attributes), nor do
I see any such subdirectories on my system.

   # find /sys/class -type d | egrep '^/sys/class/[^/]+/'
   (no output)

Is is possible to create subdirectories for class attributes?

-- 
========================================================================
                  In Soviet Russia, Google searches you!
========================================================================
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help