Hi!

quoted

--- /dev/null
+++ b/drivers/leds/blink/Kconfig

@@ -0,0 +1,20 @@
+menuconfig LEDS_BLINK
+       bool "LED Blink support"
+       depends on LEDS_CLASS
+       help
+         This option enables blink support for the leds class.
+         If unsure, say Y.

What is the purpose of the LEDS_BLINK config symbol?
Blink support for the leds class is always available, regardless of the
value of this symbol, and controlled for individual drivers by filling
in the led_classdev.blink_set() callback.

We don't really need the symbol.

quoted

+if LEDS_BLINK
+
+config LEDS_BLINK_LGM
+       tristate "LED support for Intel LGM SoC series"
+       depends on LEDS_CLASS
+       depends on MFD_SYSCON
+       depends on OF
+       help
+         Parallel to serial conversion, which is also called SSO controller,
+         can drive external shift register for LED outputs.
+         This enables LED support for Serial Shift Output controller(SSO).

What's so special about this driver that it needs a new "blink" subdir?
Isn't it an ordinary LED driver?
Looking at the code filling in the .blink_set() callback, the hardware
blink feature seems to be even optional?

So idea is to start putting drivers into subdirectories, because we
have too many of them at the moment.

simple/blink/flash/rgb, or something like that.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek